Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.20.2 update #391

Merged
merged 19 commits into from
Nov 15, 2023
Merged

1.20.2 update #391

merged 19 commits into from
Nov 15, 2023
+21,128 −19,307

Conversation

Tides
Copy link
Member

@Tides Tides commented Nov 14, 2023 •
edited
Loading

Update for 1.20.2. Lots of changes to the client login sequence

Any changes made in the Obsidian.Net.Packets namespace can be ignored cause its just all packet ids/a couple new packets

@github-actions github-actions bot added the api Relates to Obsidian.API label Nov 14, 2023
@github-actions github-actions bot added the source-generation Relates to Obsidian.SourceGenerators label Nov 14, 2023
@Tides Tides added enhancement New feature or request epic Very cool nbt Relates to Obsidian.Nbt server Relates to the server implementation priority: blocking Blocking; must be prioritized networking Relates to packet changes and net-code labels Nov 14, 2023
@Tides Tides marked this pull request as ready for review November 15, 2023 09:13
Naamloos
Naamloos approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Naamloos Naamloos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work as always. As stated in the previous comments we might want to open GitHub issues for the TODOs scattered through the project. This may also be useful for new contributors wanting to help us develop the server further.

Obsidian/Net/Packets/Play/Clientbound/UpdateAdvancementsPacket.cs Show resolved Hide resolved
@Naamloos Naamloos merged commit 63c15a8 into master Nov 15, 2023
2 checks passed
@Tides Tides deleted the 1.20.2-update branch December 7, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naamloos Naamloos Naamloos approved these changes

Assignees
No one assigned
Labels
api Relates to Obsidian.API enhancement New feature or request epic Very cool nbt Relates to Obsidian.Nbt networking Relates to packet changes and net-code priority: blocking Blocking; must be prioritized server Relates to the server implementation source-generation Relates to Obsidian.SourceGenerators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tides @Naamloos